1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
//! The [ZIP-317 block production algorithm](https://zips.z.cash/zip-0317#block-production).
//!
//! This is recommended algorithm, so these calculations are not consensus-critical,
//! or standardised across node implementations:
//! > it is sufficient to use floating point arithmetic to calculate the argument to `floor`
//! > when computing `size_target`, since there is no consensus requirement for this to be
//! > exactly the same between implementations.
use std::collections::{HashMap, HashSet};
use rand::{
distributions::{Distribution, WeightedIndex},
prelude::thread_rng,
};
use zebra_chain::{
amount::NegativeOrZero,
block::{Height, MAX_BLOCK_BYTES},
parameters::Network,
transaction::{self, zip317::BLOCK_UNPAID_ACTION_LIMIT, VerifiedUnminedTx},
transparent,
};
use zebra_consensus::MAX_BLOCK_SIGOPS;
use zebra_node_services::mempool::TransactionDependencies;
use crate::methods::get_block_template_rpcs::{
get_block_template::generate_coinbase_transaction, types::transaction::TransactionTemplate,
};
#[cfg(test)]
use super::get_block_template::InBlockTxDependenciesDepth;
#[cfg(test)]
mod tests;
/// Used in the return type of [`select_mempool_transactions()`] for test compilations.
#[cfg(test)]
type SelectedMempoolTx = (InBlockTxDependenciesDepth, VerifiedUnminedTx);
/// Used in the return type of [`select_mempool_transactions()`] for non-test compilations.
#[cfg(not(test))]
type SelectedMempoolTx = VerifiedUnminedTx;
/// Selects mempool transactions for block production according to [ZIP-317],
/// using a fake coinbase transaction and the mempool.
///
/// The fake coinbase transaction's serialized size and sigops must be at least as large
/// as the real coinbase transaction. (The real coinbase transaction depends on the total
/// fees from the transactions returned by this function.)
/// If `like_zcashd` is true, try to match the coinbase transactions generated by `zcashd`
/// in the `getblocktemplate` RPC.
///
/// Returns selected transactions from `mempool_txs`.
///
/// [ZIP-317]: https://zips.z.cash/zip-0317#block-production
pub fn select_mempool_transactions(
network: &Network,
next_block_height: Height,
miner_address: &transparent::Address,
mempool_txs: Vec<VerifiedUnminedTx>,
mempool_tx_deps: TransactionDependencies,
like_zcashd: bool,
extra_coinbase_data: Vec<u8>,
) -> Vec<SelectedMempoolTx> {
// Use a fake coinbase transaction to break the dependency between transaction
// selection, the miner fee, and the fee payment in the coinbase transaction.
let fake_coinbase_tx = fake_coinbase_transaction(
network,
next_block_height,
miner_address,
like_zcashd,
extra_coinbase_data,
);
let tx_dependencies = mempool_tx_deps.dependencies();
let (independent_mempool_txs, mut dependent_mempool_txs): (HashMap<_, _>, HashMap<_, _>) =
mempool_txs
.into_iter()
.map(|tx| (tx.transaction.id.mined_id(), tx))
.partition(|(tx_id, _tx)| !tx_dependencies.contains_key(tx_id));
// Setup the transaction lists.
let (mut conventional_fee_txs, mut low_fee_txs): (Vec<_>, Vec<_>) = independent_mempool_txs
.into_values()
.partition(VerifiedUnminedTx::pays_conventional_fee);
let mut selected_txs = Vec::new();
// Set up limit tracking
let mut remaining_block_bytes: usize = MAX_BLOCK_BYTES.try_into().expect("fits in memory");
let mut remaining_block_sigops = MAX_BLOCK_SIGOPS;
let mut remaining_block_unpaid_actions: u32 = BLOCK_UNPAID_ACTION_LIMIT;
// Adjust the limits based on the coinbase transaction
remaining_block_bytes -= fake_coinbase_tx.data.as_ref().len();
remaining_block_sigops -= fake_coinbase_tx.sigops;
// > Repeat while there is any candidate transaction
// > that pays at least the conventional fee:
let mut conventional_fee_tx_weights = setup_fee_weighted_index(&conventional_fee_txs);
while let Some(tx_weights) = conventional_fee_tx_weights {
conventional_fee_tx_weights = checked_add_transaction_weighted_random(
&mut conventional_fee_txs,
&mut dependent_mempool_txs,
tx_weights,
&mut selected_txs,
&mempool_tx_deps,
&mut remaining_block_bytes,
&mut remaining_block_sigops,
// The number of unpaid actions is always zero for transactions that pay the
// conventional fee, so this check and limit is effectively ignored.
&mut remaining_block_unpaid_actions,
);
}
// > Repeat while there is any candidate transaction:
let mut low_fee_tx_weights = setup_fee_weighted_index(&low_fee_txs);
while let Some(tx_weights) = low_fee_tx_weights {
low_fee_tx_weights = checked_add_transaction_weighted_random(
&mut low_fee_txs,
&mut dependent_mempool_txs,
tx_weights,
&mut selected_txs,
&mempool_tx_deps,
&mut remaining_block_bytes,
&mut remaining_block_sigops,
&mut remaining_block_unpaid_actions,
);
}
selected_txs
}
/// Returns a fake coinbase transaction that can be used during transaction selection.
///
/// This avoids a data dependency loop involving the selected transactions, the miner fee,
/// and the coinbase transaction.
///
/// This transaction's serialized size and sigops must be at least as large as the real coinbase
/// transaction with the correct height and fee.
///
/// If `like_zcashd` is true, try to match the coinbase transactions generated by `zcashd`
/// in the `getblocktemplate` RPC.
pub fn fake_coinbase_transaction(
network: &Network,
height: Height,
miner_address: &transparent::Address,
like_zcashd: bool,
extra_coinbase_data: Vec<u8>,
) -> TransactionTemplate<NegativeOrZero> {
// Block heights are encoded as variable-length (script) and `u32` (lock time, expiry height).
// They can also change the `u32` consensus branch id.
// We use the template height here, which has the correct byte length.
// https://zips.z.cash/protocol/protocol.pdf#txnconsensus
// https://github.com/zcash/zips/blob/main/zip-0203.rst#changes-for-nu5
//
// Transparent amounts are encoded as `i64`,
// so one zat has the same size as the real amount:
// https://developer.bitcoin.org/reference/transactions.html#txout-a-transaction-output
let miner_fee = 1.try_into().expect("amount is valid and non-negative");
let coinbase_tx = generate_coinbase_transaction(
network,
height,
miner_address,
miner_fee,
like_zcashd,
extra_coinbase_data,
);
TransactionTemplate::from_coinbase(&coinbase_tx, miner_fee)
}
/// Returns a fee-weighted index and the total weight of `transactions`.
///
/// Returns `None` if there are no transactions, or if the weights are invalid.
fn setup_fee_weighted_index(transactions: &[VerifiedUnminedTx]) -> Option<WeightedIndex<f32>> {
if transactions.is_empty() {
return None;
}
let tx_weights: Vec<f32> = transactions.iter().map(|tx| tx.fee_weight_ratio).collect();
// Setup the transaction weights.
WeightedIndex::new(tx_weights).ok()
}
/// Checks if every item in `candidate_tx_deps` is present in `selected_txs`.
///
/// Requires items in `selected_txs` to be unique to work correctly.
fn has_direct_dependencies(
candidate_tx_deps: Option<&HashSet<transaction::Hash>>,
selected_txs: &Vec<SelectedMempoolTx>,
) -> bool {
let Some(deps) = candidate_tx_deps else {
return true;
};
if selected_txs.len() < deps.len() {
return false;
}
let mut num_available_deps = 0;
for tx in selected_txs {
#[cfg(test)]
let (_, tx) = tx;
if deps.contains(&tx.transaction.id.mined_id()) {
num_available_deps += 1;
} else {
continue;
}
if num_available_deps == deps.len() {
return true;
}
}
false
}
/// Returns the depth of a transaction's dependencies in the block for a candidate
/// transaction with the provided dependencies.
#[cfg(test)]
fn dependencies_depth(
dependent_tx_id: &transaction::Hash,
mempool_tx_deps: &TransactionDependencies,
) -> InBlockTxDependenciesDepth {
let mut current_level = 0;
let mut current_level_deps = mempool_tx_deps.direct_dependencies(dependent_tx_id);
while !current_level_deps.is_empty() {
current_level += 1;
current_level_deps = current_level_deps
.iter()
.flat_map(|dep_id| mempool_tx_deps.direct_dependencies(dep_id))
.collect();
}
current_level
}
/// Chooses a random transaction from `txs` using the weighted index `tx_weights`,
/// and tries to add it to `selected_txs`.
///
/// If it fits in the supplied limits, adds it to `selected_txs`, and updates the limits.
///
/// Updates the weights of chosen transactions to zero, even if they weren't added,
/// so they can't be chosen again.
///
/// Returns the updated transaction weights.
/// If all transactions have been chosen, returns `None`.
// TODO: Refactor these arguments into a struct and this function into a method.
#[allow(clippy::too_many_arguments)]
fn checked_add_transaction_weighted_random(
candidate_txs: &mut Vec<VerifiedUnminedTx>,
dependent_txs: &mut HashMap<transaction::Hash, VerifiedUnminedTx>,
tx_weights: WeightedIndex<f32>,
selected_txs: &mut Vec<SelectedMempoolTx>,
mempool_tx_deps: &TransactionDependencies,
remaining_block_bytes: &mut usize,
remaining_block_sigops: &mut u64,
remaining_block_unpaid_actions: &mut u32,
) -> Option<WeightedIndex<f32>> {
// > Pick one of those transactions at random with probability in direct proportion
// > to its weight_ratio, and remove it from the set of candidate transactions
let (new_tx_weights, candidate_tx) =
choose_transaction_weighted_random(candidate_txs, tx_weights);
if !candidate_tx.try_update_block_template_limits(
remaining_block_bytes,
remaining_block_sigops,
remaining_block_unpaid_actions,
) {
return new_tx_weights;
}
let tx_dependencies = mempool_tx_deps.dependencies();
let selected_tx_id = &candidate_tx.transaction.id.mined_id();
debug_assert!(
!tx_dependencies.contains_key(selected_tx_id),
"all candidate transactions should be independent"
);
#[cfg(not(test))]
selected_txs.push(candidate_tx);
#[cfg(test)]
selected_txs.push((0, candidate_tx));
// Try adding any dependent transactions if all of their dependencies have been selected.
let mut current_level_dependents = mempool_tx_deps.direct_dependents(selected_tx_id);
while !current_level_dependents.is_empty() {
let mut next_level_dependents = HashSet::new();
for dependent_tx_id in ¤t_level_dependents {
// ## Note
//
// A necessary condition for adding the dependent tx is that it spends unmined outputs coming only from
// the selected txs, which come from the mempool. If the tx also spends in-chain outputs, it won't
// be added. This behavior is not specified by consensus rules and can be changed at any time,
// meaning that such txs could be added.
if has_direct_dependencies(tx_dependencies.get(dependent_tx_id), selected_txs) {
let Some(candidate_tx) = dependent_txs.remove(dependent_tx_id) else {
continue;
};
// Transactions that don't pay the conventional fee should not have
// the same probability of being included as their dependencies.
if !candidate_tx.pays_conventional_fee() {
continue;
}
if !candidate_tx.try_update_block_template_limits(
remaining_block_bytes,
remaining_block_sigops,
remaining_block_unpaid_actions,
) {
continue;
}
#[cfg(not(test))]
selected_txs.push(candidate_tx);
#[cfg(test)]
selected_txs.push((
dependencies_depth(dependent_tx_id, mempool_tx_deps),
candidate_tx,
));
next_level_dependents.extend(mempool_tx_deps.direct_dependents(dependent_tx_id));
}
}
current_level_dependents = next_level_dependents;
}
new_tx_weights
}
trait TryUpdateBlockLimits {
/// Checks if a transaction fits within the provided remaining block bytes,
/// sigops, and unpaid actions limits.
///
/// Updates the limits and returns true if the transaction does fit, or
/// returns false otherwise.
fn try_update_block_template_limits(
&self,
remaining_block_bytes: &mut usize,
remaining_block_sigops: &mut u64,
remaining_block_unpaid_actions: &mut u32,
) -> bool;
}
impl TryUpdateBlockLimits for VerifiedUnminedTx {
fn try_update_block_template_limits(
&self,
remaining_block_bytes: &mut usize,
remaining_block_sigops: &mut u64,
remaining_block_unpaid_actions: &mut u32,
) -> bool {
// > If the block template with this transaction included
// > would be within the block size limit and block sigop limit,
// > and block_unpaid_actions <= block_unpaid_action_limit,
// > add the transaction to the block template
//
// Unpaid actions are always zero for transactions that pay the conventional fee,
// so the unpaid action check always passes for those transactions.
if self.transaction.size <= *remaining_block_bytes
&& self.legacy_sigop_count <= *remaining_block_sigops
&& self.unpaid_actions <= *remaining_block_unpaid_actions
{
*remaining_block_bytes -= self.transaction.size;
*remaining_block_sigops -= self.legacy_sigop_count;
// Unpaid actions are always zero for transactions that pay the conventional fee,
// so this limit always remains the same after they are added.
*remaining_block_unpaid_actions -= self.unpaid_actions;
true
} else {
false
}
}
}
/// Choose a transaction from `transactions`, using the previously set up `weighted_index`.
///
/// If some transactions have not yet been chosen, returns the weighted index and the transaction.
/// Otherwise, just returns the transaction.
fn choose_transaction_weighted_random(
candidate_txs: &mut Vec<VerifiedUnminedTx>,
weighted_index: WeightedIndex<f32>,
) -> (Option<WeightedIndex<f32>>, VerifiedUnminedTx) {
let candidate_position = weighted_index.sample(&mut thread_rng());
let candidate_tx = candidate_txs.swap_remove(candidate_position);
// We have to regenerate this index each time we choose a transaction, due to floating-point sum inaccuracies.
// If we don't, some chosen transactions can end up with a tiny non-zero weight, leading to duplicates.
// <https://github.com/rust-random/rand/blob/4bde8a0adb517ec956fcec91665922f6360f974b/src/distributions/weighted_index.rs#L173-L183>
(setup_fee_weighted_index(candidate_txs), candidate_tx)
}